refactor: Refactor attachment upload into a service #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
suggested changes
Apr 5, 2021
There was a problem hiding this comment.
thank you for this, the controller is much cleaner now! in addition to the suggestions in the comments, could you also help with the following:
- add generic type arguments to the
RequestHandlertype forhandleEncryptedSubmission. this is because when we don't supply generic type arguments,req.bodyis typed asany, which means we lack type safety in the controller. you can look athandleEmailSubmissionfor an example, and you can make use of the typeEncryptSubmissionBodywhich is already defined inencrypt-submission.types.ts. I think theattachmentskey inEncryptSubmissionBodymight be typed wrongly because it's missing the field ID, so you may have to fix that. - avoid using
res.localswithin the controller, as everything inres.localsis typed asanyby default as well. we can just use local variables within the controller.
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Outdated
Show resolved
Hide resolved
mantariksh
suggested changes
Apr 5, 2021
mantariksh
reviewed
Apr 5, 2021
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Outdated
Show resolved
Hide resolved
|
@mantariksh made changes based on your comments, PTAL again, thanks! |
|
@frankchn thanks for the latest changes! could you also help with the following please:
|
|
@mantariksh Should I do this in another PR? The other refactorings are not really part of this PR and I don't really think should be rolled into this? |
mantariksh
reviewed
Apr 7, 2021
There was a problem hiding this comment.
@frankchn sure, we can incorporate those changes in another PR. the code looks good other than a minor point on logging as well as merge conflicts (which should be easy to resolve).
src/app/modules/submission/encrypt-submission/encrypt-submission.service.ts
Outdated
Show resolved
Hide resolved
mantariksh
approved these changes
Apr 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of the set of pull requests that addresses #149
Solution
Refactor upload attachments to its own attachments service.